Closed olexandr-konovalov closed 6 years ago
Merging #24 into master will increase coverage by
0.67%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 68.99% 69.66% +0.67%
==========================================
Files 10 11 +1
Lines 4218 4332 +114
==========================================
+ Hits 2910 3018 +108
- Misses 1308 1314 +6
Impacted Files | Coverage Δ | |
---|---|---|
read.g | 100% <ø> (ø) |
:arrow_up: |
lib/main.gi | 77.5% <100%> (-0.99%) |
:arrow_down: |
lib/auxiliar.gi | 61.91% <100%> (+0.11%) |
:arrow_up: |
lib/ExtremeSSPs.gi | 100% <100%> (ø) |
|
lib/idempot.gi | 36.7% <0%> (-4.12%) |
:arrow_down: |
init.g | 40.22% <0%> (+0.09%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ba92e6f...302005a. Read the comment docs.
@MSugandha tests fail because of this (what somehow has not been detected when trying to test locally before committing & pushing):
Syntax warning: Unbound global variable in /home/travis/build/gap-packages/wed\
derga/gaproot/pkg/wedderga/lib/ExtremeSSPs.gi:73
RANCs:=[];
You can now fix this in the ExtremeSSPs
branch, then do
git add lib/ExtremeSSPs.gi
git commit --amend
git push --force
to update the last commit in the pull request.
@MSugandha I've tried to improve code coverage and add the test for PrimitiveCentralIdempotentsByExtSSP
. It does not work at the moment:
gap> G:=DihedralGroup(16);
<pc group of size 16 with 4 generators>
gap> QG:=GroupRing(Rationals,G);
<algebra-with-one over Rationals, with 4 generators>
gap> PrimitiveCentralIdempotentsByExtSSP(QG);
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `CallFuncList' on 2 arguments at /Users/alexk/GITREPS/gap/lib/methsel2.g:250 called from
ESSP( G ) at /Users/alexk/Library/Preferences/GAP/pkg/wedderga/lib/ExtremeSSPs.gi:201 called from
<function "PrimitiveCentralIdempotentsByExtSSP">( <arguments> )
called from read-eval loop at *stdin*:12
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
brk>
@MSugandha great!
testing: /Users/alexk/Library/Preferences/GAP/pkg/wedderga/tst/ExtremeSSPs.tst
37111 ms (2429 ms GC) and 4.65GB allocated for ExtremeSSPs.tst
testing: /Users/alexk/Library/Preferences/GAP/pkg/wedderga/tst/bugfix.tst
14756 ms (1202 ms GC) and 1.35GB allocated for bugfix.tst
testing: /Users/alexk/Library/Preferences/GAP/pkg/wedderga/tst/wedderga01.tst
822 ms (109 ms GC) and 56.7MB allocated for wedderga01.tst
testing: /Users/alexk/Library/Preferences/GAP/pkg/wedderga/tst/wedderga02.tst
7912 ms (736 ms GC) and 793MB allocated for wedderga02.tst
testing: /Users/alexk/Library/Preferences/GAP/pkg/wedderga/tst/wedderga03.tst
1937 ms (167 ms GC) and 205MB allocated for wedderga03.tst
testing: /Users/alexk/Library/Preferences/GAP/pkg/wedderga/tst/wedderga04.tst
24749 ms (4360 ms GC) and 1.06GB allocated for wedderga04.tst
testing: /Users/alexk/Library/Preferences/GAP/pkg/wedderga/tst/wedderga05.tst
1096 ms (151 ms GC) and 111MB allocated for wedderga05.tst
testing: /Users/alexk/Library/Preferences/GAP/pkg/wedderga/tst/wedderga06.tst
362 ms (109 ms GC) and 27.2MB allocated for wedderga06.tst
testing: /Users/alexk/Library/Preferences/GAP/pkg/wedderga/tst/wedderga07.tst
16185 ms (1185 ms GC) and 1.62GB allocated for wedderga07.tst
testing: /Users/alexk/Library/Preferences/GAP/pkg/wedderga/tst/wedderga08.tst
360 ms (119 ms GC) and 16.8MB allocated for wedderga08.tst
-----------------------------------
total 105290 ms (10567 ms GC) and 9.87GB allocated
#I No errors detected while testing
I have rebased this onto master branch to resolve conflict in one of the test files, and force-pushed the branch. Now Travis CI tests pass!
Thanks @MSugandha @gkbakshi - this is now in the master branch! We should complete the documentation and this will be then ready for the release.
Work in progress to incorporate @MSugandha's code for extremely strong Shoda pairs