gap-packages / wedderga

Wedderburn Decomposition of Group Algebras

https://gap-packages.github.io/wedderga/

GNU General Public License v2.0

3 stars 6 forks source link

Allen's fixes in LocalIndexAtOddP and LocalIndexAtTwo #52

Closed olexandr-konovalov closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #52 into master will increase coverage by 0.17%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   80.48%   80.66%   +0.17%     
==========================================
  Files          11       11              
  Lines        4647     4690      +43     
==========================================
+ Hits         3740     3783      +43     
  Misses        907      907

olexandr-konovalov commented 4 years ago

Thanks for providing the test @drallenherman @angeldelriomateos - it passes under the new version in this pull request, but I can not get it failing under the current version of the package, what I have tried in another pull request #55. So I am confused...

olexandr-konovalov commented 4 years ago

@drallenherman @angeldelriomateos what to do with this? Is it now incorporated into #57 ?

olexandr-konovalov commented 4 years ago

Closing this PR - the fix is now included in #58.