search

gap-packages / wedderga

Wedderburn Decomposition of Group Algebras
https://gap-packages.github.io/wedderga/
GNU General Public License v2.0
3 stars 6 forks source link

Remove FactoringCycAlg #73

Closed angeldelriomateos closed 4 years ago

angeldelriomateos commented 4 years ago

I guess this should go fast. Simply Remove FactoringCycAlg

olexandr-konovalov commented 4 years ago

Ok, but why you submit it into gap-packages:FactoringCycAlg branch? It should be submitted into divalg. I will fix that now.

olexandr-konovalov commented 4 years ago

Travis tests were not triggered, because initially this was submitted to a wrong branch. I have checked with grep that indeed FactoringCycAlg is not used anywhere, and not mentioned anywhere, so should be fine to remove it without a test here (anyway, it will be tested in divalg). The commit looks OK, does not have any accidental changes elsewhere.

olexandr-konovalov commented 4 years ago

Tests of this in divalg went well too - thanks!