search

gap-system / PackageDistro

The GAP package distribution is managed via this repository
https://gap-system.github.io/PackageDistro/
GNU General Public License v2.0
4 stars 8 forks source link

[atlasrep] Update to 2.1.7 #821

Closed gap-package-distribution-bot[bot] closed 1 year ago

gap-package-distribution-bot[bot] commented 1 year ago
gap-package-distribution-bot[bot] commented 1 year ago

Package Evaluation Report for GAP master

Job Properties

Testing: master/2023-09-01-21:43:35-9cb67296 vs master/2023-09-01-21:13:20-3ab20e58

Generated by Workflow: https://github.com/gap-system/PackageDistro/actions/runs/6054007103

In total, 156 packages were tested, out of which 151 succeeded, 1 failed and 4 were skipped.

:exclamation: Packages still failing

1 package(s) failed tests also on the previous version.

:heavy_check_mark: Packages still succeeding

151 package(s) succeeded tests also on the previous version.

Click to show packages! - 4ti2interface 2023.02-04 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430926782) - ace 5.6.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430926928) - aclib 1.3.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430927030) - agt 0.3.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430927130) - alnuth 3.2.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430927230) - anupq 3.3.0 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430927344) - atlasrep 2.1.7 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430927428) - autodoc 2023.06.19 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430927528) - automata 1.15 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430927616) - automgrp 1.3.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430927749) - autpgrp 1.11 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430927844) - cap 2023.09-01 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430927956) - caratinterface 2.3.5 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430928061) - cddinterface 2022.11.01 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430928158) - circle 1.6.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430928257) - classicpres 1.22 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430928363) - cohomolo 1.6.11 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430928505) - congruence 1.2.5 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430928637) - corelg 1.56 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430928770) - crime 1.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430928888) - crisp 1.4.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430929022) - crypting 0.10.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430929143) - cryst 4.1.26 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430929252) - crystcat 1.1.10 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430929389) - ctbllib 1.3.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430929515) - cubefree 1.19 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430929630) - curlinterface 2.3.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430929762) - cvec 2.8.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430929902) - datastructures 0.3.0 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430930016) - deepthought 1.0.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430930157) - design 1.8 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430930266) - difsets 2.3.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430930390) - digraphs 1.6.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430930525) - edim 1.3.7 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430930647) - example 4.3.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430930771) - examplesforhomalg 2023.08-02 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430930903) - factint 1.6.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430931039) - ferret 1.0.9 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430931172) - fga 1.5.0 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430931289) - fining 1.5.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430931397) - float 1.0.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430931515) - format 1.4.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430931619) - forms 1.2.9 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430931741) - fplsa 1.2.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430931857) - fr 2.4.12 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430931978) - francy 2.0.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430932093) - fwtree 1.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430932186) - gapdoc 1.6.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430932289) - gauss 2023.02-04 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430932386) - gaussforhomalg 2023.08-01 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430932497) - gbnp 1.0.5 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430932635) - generalizedmorphismsforcap 2023.08-02 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430932746) - genss 1.6.8 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430932862) - gradedmodules 2023.08-01 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430932977) - gradedringforhomalg 2023.08-01 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430933092) - grape 4.9.0 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430933236) - groupoids 1.73 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430933352) - grpconst 2.6.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430933459) - guarana 0.96.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430933586) - guava 3.18 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430933692) - hap 1.58 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430933812) - hapcryst 0.1.15 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430933959) - hecke 1.5.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430934104) - help 3.5 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430934224) - homalg 2023.08-02 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430934362) - homalgtocas 2023.08-01 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430934495) - idrel 2.45 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430934621) - images 1.3.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430934730) - intpic 0.3.0 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430934846) - io 4.8.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430934995) - io_forhomalg 2023.02-04 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430935132) - irredsol 1.4.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430935237) - json 2.1.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430935352) - jupyterkernel 1.5.0 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430935508) - jupyterviz 1.5.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430935629) - kan 1.36 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430935764) - kbmag 1.5.11 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430935879) - laguna 3.9.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430936001) - liealgdb 2.2.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430936087) - liepring 2.8 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430936205) - liering 2.4.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430936303) - linearalgebraforcap 2023.08-08 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430936458) - localizeringforhomalg 2023.08-02 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430936603) - loops 3.4.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430936723) - lpres 1.0.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430936829) - majoranaalgebras 1.5.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430936926) - mapclass 1.4.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430937048) - matgrp 0.70 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430937164) - matricesforhomalg 2023.08-02 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430937268) - modisom 2.5.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430937367) - modulepresentationsforcap 2023.09-01 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430937461) - modules 2023.08-02 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430937669) - monoidalcategories 2023.08-11 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430937814) - nconvex 2022.09-01 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430937913) - nilmat 1.4.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430938033) - nock 1.5 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430938153) - normalizinterface 1.3.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430938247) - nq 2.5.10 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430938350) - numericalsgps 1.3.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430938456) - openmath 11.5.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430938541) - orb 4.9.0 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430938659) - packagemanager 1.4.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430938766) - patternclass 2.4.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430938875) - permut 2.0.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430938991) - polenta 1.3.10 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430939116) - polymaking 0.8.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430939209) - primgrp 3.4.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430939337) - profiling 2.5.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430939440) - qpa 1.34 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430939549) - quagroup 1.8.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430939650) - radiroot 2.9 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430939765) - rcwa 4.7.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430939866) - rds 1.8 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430939980) - recog 1.4.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430940096) - repndecomp 1.3.0 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430940240) - repsn 3.1.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430940352) - resclasses 4.7.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430940455) - ringsforhomalg 2023.08-02 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430940591) - sco 2023.08-01 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430940741) - scscp 2.4.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430940843) - sglppow 2.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430941162) - sgpviz 0.999.5 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430941347) - simpcomp 2.1.14 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430941608) - singular 2023.02.09 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430941802) - sl2reps 1.1 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430941913) - sla 1.5.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430942026) - smallgrp 1.5.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430942161) - smallsemi 0.6.13 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430942264) - sonata 2.9.6 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430942379) - sophus 1.27 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430942496) - sotgrps 1.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430942619) - spinsym 1.5.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430942731) - standardff 0.9.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430942843) - symbcompcc 1.3.2 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430942943) - thelma 1.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430943053) - tomlib 1.2.9 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430943186) - toolsforhomalg 2023.07-01 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430943305) - toric 1.9.5 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430943422) - toricvarieties 2022.07.13 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430943529) - transgrp 3.6.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430943651) - ugaly 4.1.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430943744) - unipot 1.5 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430943851) - unitlib 4.2.0 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430943952) - utils 0.82 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430944064) - uuid 0.7 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430944174) - walrus 0.9991 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430944292) - wedderga 4.10.4 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430944429) - xmod 2.91 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430944554) - xmodalg 1.23 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430944680) - yangbaxter 0.10.3 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430944800) - zeromqinterface 0.14 [(success)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430944925)

:heavy_minus_sign: Packages that were skipped

4 package(s) skipped tests also on the previous version.

Click to show packages! - browse 1.8.21 [(skipped)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430650337) - itc 1.5.1 [(skipped)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430650337) - polycyclic 2.16 [(skipped)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430650337) - xgap 4.31 [(skipped)](https://github.com/gap-system/PackageDistro/actions/runs/6054007103/job/16430650337)
fingolfin commented 1 year ago

@ThomasBreuer apparently the new AtlasRep creates a read-only variable ZZ which breaks the CAP/homalg test suites...

ThomasBreuer commented 1 year ago

@fingolfin ZZ is a (documented) operation from the StandardFF package. AtlasRep version 2.1.7 introduces a new dependency to StandardFF as a suggested package.

fingolfin commented 1 year ago

OK. I guess we can ask @zickgraf if they can avoid using ZZ in their test suite as a free variable.

zickgraf commented 1 year ago

I have created https://github.com/homalg-project/CAP_project/pull/1455 for CAP_project. Ping @mohamed-barakat for homalg_project.

However, I think it is not very polite of packages (or of GAP itself) to just "occupy" those short names like Z, ZZ, E, EE etc. Of course this makes it very convenient to write code using those functions, but I am always annoyed when trying to do something like X := ...; Y := ...; Z := ...; in the REPL, where X and Z are already occupied. My workaround usually was XX := ...; YY := ...; ZZ := ...;, which now also breaks. I would much prefer if packages would use longer names. If one really uses those functions excessively, one could always create a local alias with a short name, without polluting the global namespace.

ThomasBreuer commented 1 year ago

@zickgraf

fingolfin commented 1 year ago

I agree with both of you: it is annoying that X, E, Z, ..., and now ZZ are "blocked"; but also there is a clear rule to avoid this ("don't use variables starting with an upper case letter"), and a simple workaround for test files, too (namely using #@local -- though it has the drawback that these examples then are not trivial to reproduce interactively).

Anyway, thanks @zickgraf for preparing a patch, and it seems this was already released, great. To be on the safe side long term, you may wish to rename ZZZ to zz or so... but for now it is of course perfectly fine 😃)

mohamed-barakat commented 1 year ago

but also there is a clear rule to avoid ("don't use variables starting with an upper case letter")

Grepping in gap/lib for "G:=", "U:=" one finds not only occurrences as local variables in the code but also in the GAPDoc sections, but maybe this GAPDoc code is not tested. So I assume the rule is a strong recommendation.

I am aware that these issues are consequences of GAP missing the concept of namespaces and that it would be a considerable amount of work to introduce them, so I am not complaining.

I will try to replace " ZZ" with " zz" in the homalg packages and see what happens.

fingolfin commented 1 year ago

The CAP fixes by @zickgraf helped but of course we still have failures in various homalg packages, so waiting for new release of these:

mohamed-barakat commented 1 year ago

Our CIs are failing although they are not tested with LoadAllPackages( ). This probably means that standard GAP is now marking ZZ read-only. Is there a way to undo this change in the near future?

Side note: QPA2 is now also failing due to a conflict in the declaration of AsVector.

fingolfin commented 1 year ago

I don't understand, I thought you replaced all uses of ZZ?

mohamed-barakat commented 1 year ago

Yes, we did in the deposited packages. I assumed this would be enough :)

ThomasBreuer commented 1 year ago

@mohamed-barakat

This probably means that standard GAP is now marking ZZ read-only. Is there a way to undo this change in the near future?

I do not understand this statement. The operation ZZ belongs to the StandardFF package. It is bound and then readonly as soon as this package is loaded. Making ZZ in StandardFF not readonly would be wrong.

The clash with user variables in CAP/homalg packages occurs since AtlasRep suggests loading StandardFF, thus I guess that "standard GAP" means GAP with some packages, one of them being AtlasRep. If one really wants to avoid loading StandardFF, one could try to load AtlasRep explicitly with the OnlyNeeded option, but for that one has to make sure that AtlasRep has not been loaded before.

mohamed-barakat commented 1 year ago

The clash with user variables in CAP/homalg packages occurs since AtlasRep suggests loading StandardFF, thus I guess that "standard GAP" means GAP with some packages, one of them being AtlasRep.

Yes.

I do not understand this statement. The operation ZZ belongs to the StandardFF package. It is bound and then readonly as soon as this package is loaded. Making ZZ in StandardFF not readonly would be wrong.

I was not suggesting making ZZ read/write. I was asking if it would be possible to rename ZZ in StandardFF into something different :) If the answer is no we have to rename all occurrences of ZZ into something else in our non-deposited packages as well.

mohamed-barakat commented 1 year ago

In the meanwhile, I have looked into StandardFFand now understand the logic behind using ZZ.

zickgraf commented 1 year ago

Side note: QPA2 is now also failing due to a conflict in the declaration of AsVector.

See https://github.com/frankluebeck/StandardFF/pull/6 for the clash of "AsVector" with QPA2. For now I will simply delete StandardFF from our CI completely.

fingolfin commented 1 year ago

Unfortunately QPA2 is not a deposited package and hence clashes in it with deposited packages are not detected. So in this case I am afraid the onus is on QPA2 maintainers to work something out with the StandardFF maintainer (Frank Lübeck) and/or to change their package.