gap-system / gap

Main development repository for GAP - Groups, Algorithms, Programming, a System for Computational Discrete Algebra
https://www.gap-system.org
GNU General Public License v2.0
762 stars 158 forks source link

`IsomorphismGroups` regression in 4.13.0 #5708

Closed antonio-rojas closed 1 week ago

antonio-rojas commented 2 weeks ago

Observed behaviour

With 4.13.0 or current master:

gap> G:=Group([ (2,11,20)(3,10,19)(4,9,12)(5,8,13)(6,15,17)(7,14,18), (2,20)(3,4)(5,7)(8,18)(9,19)(10,12)(13,14)(15,17), (1,2)(3,20)(6,18)(7,19)(8,12)(9,11)(13,15)(16,17) ]);
Group([ (2,11,20)(3,10,19)(4,9,12)(5,8,13)(6,15,17)(7,14,18), (2,20)(3,4)(5,7)(8,18)(9,19)(10,12)(13,14)(15,17), (1,2)(3,20)(6,18)(7,19)(8,12)(9,11)
  (13,15)(16,17) ])
gap> H:=Group([ (1,2,3,4,5), (3,4,5), (6,7) ]);
Group([ (1,2,3,4,5), (3,4,5), (6,7) ])
gap> IsomorphismGroups(G,H);

Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `Representative' on 1 arguments
The 1st argument is 'fail' which might point to an earlier problem
 at /usr/share/gap/lib/methsel2.g:250 called from
Representative( of ) at /usr/share/gap/lib/morpheus.gi:538 called from
AssignNiceMonomorphismAutomorphismGroup( A, G ); at /usr/share/gap/lib/morpheus.gi:2565 called from
NiceMonomorphism( obj1 ) at /usr/share/gap/lib/grpnice.gi:313 called from
ClosureGroup( G, gen ) at /usr/share/gap/lib/grp.gi:2617 called from
ClosureGroup( G, obj ) at /usr/share/gap/lib/grp.gi:2644 called from
...  at *stdin*:3

Expected behaviour

With 4.12.2:

gap> G:=Group([ (2,11,20)(3,10,19)(4,9,12)(5,8,13)(6,15,17)(7,14,18), (2,20)(3,4)(5,7)(8,18)(9,19)(10,12)(13,14)(15,17), (1,2)(3,20)(6,18)(7,19)(8,12)(9,11)(13,15)(16,17) ]);
Group([ (2,11,20)(3,10,19)(4,9,12)(5,8,13)(6,15,17)(7,14,18), (2,20)(3,4)(5,7)(8,18)(9,19)(10,12)(13,14)(15,17), (1,2)(3,20)(6,18)(7,19)(8,12)(9,11)
  (13,15)(16,17) ])
gap> H:=Group([ (1,2,3,4,5), (3,4,5), (6,7) ]);
Group([ (1,2,3,4,5), (3,4,5), (6,7) ])
gap> IsomorphismGroups(G,H);

[ (2,11,20)(3,10,19)(4,9,12)(5,8,13)(6,15,17)(7,14,18), (2,20)(3,4)(5,7)(8,18)(9,19)(10,12)(13,14)(15,17), (1,2)(3,20)(6,18)(7,19)(8,12)(9,11)(13,
    15)(16,17) ] -> [ (1,2,3), (1,3)(4,5)(6,7), (2,5)(3,4)(6,7) ]

Copy and paste GAP banner (to tell us about your setup)

 ┌───────┐   GAP 4.12.2 of 2022-12-18
 │  GAP  │   https://www.gap-system.org
 └───────┘   Architecture: x86_64-pc-linux-gnu-default64-kv8
 Configuration:  gmp 6.3.0, GASMAN, readline
 Loading the library and packages ...
 Packages:   Alnuth 3.2.1, AtlasRep 2.1.6, AutPGrp 1.11, CRISP 1.4.6, CTblLib 1.3.4, FactInt 1.6.3, FGA 1.4.0, GAPDoc 1.6.6, IRREDSOL 1.4.4, 
             LAGUNA 3.9.5, Polenta 1.3.10, Polycyclic 2.16, PrimGrp 3.4.3, RadiRoot 2.9, ResClasses 4.7.3, SmallGrp 1.5.1, Sophus 1.27, TomLib 1.2.9, 
             TransGrp 3.6.3, utils 0.81
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
antonio-rojas commented 2 weeks ago

Caused by 58f31c6c748db35592f4e0b19f4db4e0d6acedbe

fingolfin commented 1 week ago

Thanks for the report @antonio-rojas we'll have a look

(Ping @hulpke)

hulpke commented 1 week ago

Fixed (harmless bug, will only lead to error messages).