Closed lgoettgens closed 1 month ago
You'll need this at the top of the file:
#include <julia_threads.h> // for jl_get_ptls_states
#if JULIA_VERSION_MAJOR == 1 && JULIA_VERSION_MINOR == 7
// workaround issue with Julia 1.7 headers which "forgot" to export this
// function
JL_DLLEXPORT void * jl_get_ptls_states(void);
#endif
Still crashes :-(
Still lots of compiler warninga in the bundled GAP. And it compiles GAP twice, gotta look into that
We really should ask the Julia folks to add jl_gc_new_weakref
back to headers given that jl_gc_new_weakref_th
existed in older version but wasn't in the headers (and was it exported?)
Still lots of compiler warninga in the bundled GAP. And it compiles GAP twice, gotta look into that
The double compilation is due to the way that setup_override_dir.jl
works. It expects gap to already be compiled the usual way, then replaces two files and re-compiles but this time with julia gc.
We really should ask the Julia folks to add
jl_gc_new_weakref
back to headers given thatjl_gc_new_weakref_th
existed in older version but wasn't in the headers (and was it exported?)
Julia PR was merged so we can close this. Thanks for the effort, @lgoettgens !
As discussed in https://github.com/oscar-system/GAP.jl/issues/1032#issuecomment-2435216269. cc @fingolfin
Text for release notes
not needed