Freebsd fixes - Githubissues

gap-system / ward

Code generation tool needed for HPC-GAP

Boost Software License 1.0

3 stars 7 forks source link

Freebsd fixes #40

Closed ChrisJefferson closed 7 years ago

ChrisJefferson commented 7 years ago

This adds two extensions needed for FreeBSD:

Add the C11 keyword _Thread_local.
Allow bitfield definitions like int x : a+b. Previously we just allowed an integer constant, but you can have an arbitrary expression. I'm not sure expression is exactly the right thing (I might now be allowing invalid C), but I don't mind if ward accepts and handles a super-set of C (the compiler can reject the invalid code later).

dimpase commented 7 years ago

OK, this works for me, thanks!

dimpase commented 7 years ago

It was pretty easy review, I thought I could just merge it---as I did have the permission after all. Apologies, in case...

fingolfin commented 7 years ago

@dimpase no worries. the merge just made us realize that right now a lot of people have the right to do a lot of things, so we reorganized the team structure a bit. For pull requests, we generally want at least one "regular" committer to approve the PR; that said, reviews and approval of PRs is welcome from everybody.

fingolfin commented 7 years ago

Oh, and let me stress: I don't think you did anything wrong

fingolfin commented 7 years ago

Unfortunately this PR broke OS X support :-(.