search

gaperez64 / acacia-bonsai

A minimal implementation of reactive synthesis via universal co-Buchi automata using antichains
GNU General Public License v3.0
4 stars 3 forks source link

Hardcoded vector types in some code #22

Closed ncharl closed 1 year ago

ncharl commented 1 year ago

The configuration file has a line to define the type used in vectors (states in the safety game) which is used in many places such as in the main file here, but in some places such as on this line in k-bounded_safety_aut.hh, char is used instead of VECTOR_ELT_T and so if the configuration is changed to short for example to allow larger values, this line would not behave correctly. Should this be changed?

michaelcadilhac commented 1 year ago

That sounds sensible, yes; go ahead.

gaperez64 commented 1 year ago

This was resolved when merging #29. Thanks @ncharl !