search

gaperez64 / acacia-bonsai

A minimal implementation of reactive synthesis via universal co-Buchi automata using antichains
GNU General Public License v3.0
4 stars 3 forks source link

Allow for more accepting states #36

Open gaperez64 opened 1 year ago

gaperez64 commented 1 year ago

@michaelcadilhac I've found a benchmark for which the assertion below does not hold. See 07.tlsf in the realizable benchmarks in tests. Why did we not use at least int?

https://github.com/gaperez64/acacia-bonsai/blob/9e75f86d20599f6276c8ff9a1b37be0e06b555e4/src/boolean_states/forward_saturation.hh#L32

michaelcadilhac commented 9 months ago

I'd call this premature optimization. This allows for a slightly better data structure for the loop that follows, in the code. I'm "refreshing" all integer types with fixed width integer types right now, and this will solve that.

gaperez64 commented 8 months ago

Is it solved now @michaelcadilhac ?

gaperez64 commented 3 months ago

I still see the assertion in the code.