gaphor / gaphor

Gaphor is the simple modeling tool
https://gaphor.org
1.87k stars 200 forks source link

Improve Greeter Interface to Update Buttons and Title on Stack Change #1300

Closed danyeaw closed 2 years ago

danyeaw commented 2 years ago

Is your feature request related to a problem?

The current greeter, which although is a really great addition, was implemented as a Window Stack which changed the middle of the stack, but not the action bar or titlebar. This results in a selection buttons not doing anything on certain screens and the title can sometimes be confusing. This was also reported by @vanillajonathan in https://github.com/gaphor/gaphor/issues/973.

For example, on the recent model Window, the Recent Model... doesn't do anything. The title bar says Open a Gaphor Model instead of Recent Models: image

On the Create Model Window, the Create New Model... button doesn't do anything. The title bar says Open a Gaphor Model instead of Create New Model: image

This is also evident when selecting Open a Model or New Model from the hamburger menu, since the same window stack opens.

Describe the solution you'd like

Here are a couple of mockups:

Screenshot from 2022-01-16 09-06-59

Screenshot from 2022-01-16 08-51-24

Would Open Other Model... or just Open Model... be better than Existing model? I wasn't sure about that or not.

I can submit a PR once we are aligned on improvements :+1:

amolenaar commented 2 years ago

Resolved by #1301