search

gaphor / gaphor

Gaphor is the simple modeling tool
https://gaphor.org
1.87k stars 200 forks source link

Association direction arrow overlapping with name #1451

Closed HighKingofMelons closed 2 years ago

HighKingofMelons commented 2 years ago

Describe the bug

Direction arrow on associations overlapping name

To Reproduce

Steps to reproduce the behavior:

  1. Create two classes next to each other
  2. Create association from left to right
  3. Give association a name
  4. Toggle display direction of association

Expected behavior

Arrow would appear on the opposite side of the association compared to the name, or better yet the arrow being attached to the front or back of the name fx. '◂ Name', '▾ Name', '▸ Name' or '▴ Name'

Screenshots

arrowhas

OS

Linux

Version

Version of Gaphor: 2.9.2, Flatpak from flathub

Additional information

Using Fedora 35

amolenaar commented 2 years ago

image This is better. I changed the arrow to always be placed on the posite side of the text.

I also added a bit more padding to the property text at the association ends, as suggested by @Toorero. There are still a few angles where the text is overlapped by a few pixels, but it remains readable.

danyeaw commented 2 years ago

@all-contributors please add @HighKingofMelons for bug

allcontributors[bot] commented 2 years ago

@danyeaw

I've put up a pull request to add @HighKingofMelons! :tada: