gaplo917 / Ligatured-Hack

Automatically patch latest Hack Font with latest JetBrains Mono / FiraCode Ligatures
GNU General Public License v3.0
269 stars 12 forks source link

Fira Code Ligatures and Monospace flag #11

Open drventure opened 2 years ago

drventure commented 2 years ago

First off, Great work! I love Hack overall and the combinations you've got are stellar.

So a couple notes I've noticed 1) The resultant fonts don't appear to be marked as MONOSPACE fonts completely correctly, so, for instance, certain applications that ONLY list monospace fonts won't list Hack FC Ligatured CCG, but WILL list Fira Code as a selection. The original Hack has this same problem so I doubt it's anything your stuff is doing. But it would be nice if they were marked correctly. 2) The Fira Code ligatures in the combined HACK font don't seem to match up in some cases. For instance, choose FIRA CODE in notepad and type a line of 10 "=" signs. You'll get a continuous double line for the whole width. BUT switch to Hack FC ligatured CCG and the line will clearly have breaks between all the equal signs.

Both minor issues. But I thought I'd let you know in any case.

gaplo917 commented 2 years ago

@drventure Thank you for your appreciation! I would like to have more information to proceed more efficiently,

For 1., could you add some steps or sample application to reproduce?

For 2., yes, this is expected. The feature you mentioned is on or above Fira Code v4, but the current build only supports v3.1.

Reference issues: https://github.com/tonsky/FiraCode/issues/1100

All hyphen and equals-based arrows, underscores and numbersigns were removed as individual characters in 4. They are now built from segments to allow for infinite-length arrows

drventure commented 2 years ago

Hi

Thanks for the response. I can show a couple examples

First is Visual Studio 2022 8UNWPnHhF7

Notice that the wording above the dropdown even says that Monospaced fonts are in bold. and that def appears to be the case.

But note this devenv_4xnr88icv1

FiraCode is bolded but Hack FC ligatured CCG is not.

Now, VS allows you to pick the font even though it's not technically "monospace", so everythings fine.

Now, take a look at the Hex Editor HxD (free open source, pick it up here https://mh-nexus.de/en/hxd/

In this case, the font selector dialog ONLY lists Fixed width fonts, so Fira Code is listed, but Hack is not. HxD_nZXF9KPmkh

HxD_fnt7l9womp

I've used several font tools (I'm no font author at all, so I'm not versed on the terminology +at all+) to try and spot WHY Fira Code would be considered "Fixed Width" and Hack not (also Inconsolata BTW, so this isn't a problem limited to just Hack. Unfortunated, I haven't been able to spot anything.

The only clue I've found is that one article mentioned that in order to be considered "Fixed width" +literally every glyph+ must have the same width, even glyphs that are supposed to be set to 0 width. But they check that they recommended for that, Hack passed, so I'm still clueless why.