search

gar-r / nekometer

GNU General Public License v3.0
1 stars 0 forks source link

Suggestions! #4

Closed Kkthnx closed 5 months ago

Kkthnx commented 5 months ago

I love your damage meter! I would love to suggest matching up and down arrow for consistency. This helps follow your style you are going for?

1) Class icons left side of name. 2) White text or yellow. White looks better against yellow rogue with yellow text 🗡️

https://i.imgur.com/uPN9Pob.png

Kkthnx commented 5 months ago

Do you feel like

button:SetHighlightTexture("Interface\\Buttons\\ButtonHilight-Square")

should be

button:SetHighlightTexture(texture)

Let me know if there is anything you need or testing. I do enjoy your addon with my UI (KkthnxUI)

image

gar-r commented 5 months ago

button:SetHighlightTexture("Interface\\Buttons\\ButtonHilight-Square")

should be

button:SetHighlightTexture(texture)

@Kkthnx thank you for the feedback! Can you please elaborate why you suggest this change?

AFAIK the SetHighlightTexture function sets the texture when the UI element is highlighted (i.e. mouse over). Combined with SetBlendMode("ADD") this will produce a rectangular highlight around the buttons. (For reference: https://github.com/Gethe/wow-ui-textures/blob/live/Buttons/ButtonHilight-Square.PNG)

Kkthnx commented 5 months ago

So its basically just highlights the button brighter. It flows more with designs and keeps it clean. Instead of having a completely off square button highlight look as it currently is set to. Let me show you.

https://i.imgur.com/rTrjawl.gif

gar-r commented 5 months ago

Agreed, looks cleaner on your image. Will update it.

gar-r commented 5 months ago

5 and #6 is merged to the v2 branch (which is planned to release before TWW).

It can be tested directly from source, or from the CurseForge latest alpha package (https://www.curseforge.com/wow/addons/nekometer/files/all?page=1&pageSize=20&showAlphaFiles=show).

7 is deferred for now, but keeping it open.