search

garabik / grc

generic colouriser
http://kassiopeia.juls.savba.sk/~garabik/software/grc.html
Other
1.9k stars 162 forks source link

File `grc.bashrc` missing in the Debian package #136

Open ferenczy opened 5 years ago

ferenczy commented 5 years ago

I'm not sure if this is the right place to report it, it depends on who's maintaining the Debian package, but the Debian package in Debian 10's repository is missing the alias file for bash /etc/grc.bashrc. There're only grc.fish and grc.zsh files.

BTW there's an inconsistency in the naming of those files - in case of fish and zsh, the alias file contains the name of the shell, but in case of bash, it contains the name of bash's configuration file.

laoshaw commented 4 years ago

same here, bash is probably more widely used, it surprises me there is no grc.bash on ubuntus

lylemoffitt commented 3 years ago

Came to report this. For whatever reason it's just not installed. 

$ dpkg -s grc
Package: grc
Status: install ok installed
Priority: optional
Section: text
Installed-Size: 185
Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
Architecture: all
Version: 1.11.3-1
Depends: python3:any
Conffiles:
 /etc/grc.conf 85a82cd347fb1da126661498efb52e71
 /etc/grc.fish 7ec1b5b09bdb2e8283f0bfd98b223b8b
 /etc/grc.zsh c45930309dbce3d21a2a950439d7f53c
Description: generic colouriser for everything
 generic colouriser, can be used to colourise logfiles,
 output of commands, arbitrary text....
 configured via regexp's.
Original-Maintainer: Radovan Garabík <garabik@kassiopeia.juls.savba.sk>

I'm not sure why, but it's specifically removed here: https://github.com/garabik/grc/blob/master/debian/rules#L23

Not much to go on from the commit either, but clearly intentional. https://github.com/garabik/grc/commit/8baa92d61616ba1dcf61a6cbebb7786a096e8194

ferenczy commented 3 years ago

@garabik could explain the reason I guess.

richarson commented 3 years ago

I see that grc.sh is copied to /etc/profile.d/ by install.sh, but grc.fish and grc.zsh get copied to /etc/, I'm not sure why the difference.

Usually for bash, whatever you put in /etc/profile.d/ gets sourced from /etc/profle, I don't know how fish an zsh work in that regard.

Should the three files be copied to /etc/profile.d/?

HaleTom commented 2 years ago

There's a good case for grc.sh not being in /etc/profile.d/: grc.sh unnecessary double source; variable #199

The file gets sourced before the flag can be set by the user -- not all users are root :)