search

garabik / grc

generic colouriser
http://kassiopeia.juls.savba.sk/~garabik/software/grc.html
Other
1.88k stars 160 forks source link

install.sh does not include grc.zsh and grc.fish #60

Open elnappo opened 7 years ago

elnappo commented 7 years ago

Is there a reason why grc.zshand grc.fish are not included in the install.shscript? Further it seams that not all executable are included in these integrations e.g. uptime is missing in grc.zsh but also in the grc plugin from oh-my-fish.

Maybe relevant: https://github.com/Homebrew/homebrew-core/blob/master/Formula/grc.rb https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/grc

iax7 commented 6 years ago

I think this is already fixed. grc.zsh and grc.fish are included in install.sh.

elnappo commented 6 years ago

Your'e right. I found another inconsistency, the README.markdown says that grc.bashrc is at /etc/grc.bashrc but install.sh places the file under /etc/profile.d/grc.bashrc.

Wouldn't it be better to place these file in the same location e.g. /etc/ or /usr/local/etc on macOS? But I think /etc/ ist not the right place for grc.bashrc, grc.fish and grc.zsh as these file are not config files in contrast to /etc/grc.conf

elnappo commented 6 years ago

Furthermore, grc.bashrc, grc.fish and grc.zsh are not supporting the same commands.