garaemon / vscode-emacs-tab

BSD 3-Clause "New" or "Revised" License
14 stars 11 forks source link

Fix a bug and package dependencies #15

Closed y-kitamu closed 2 years ago

y-kitamu commented 2 years ago

Hi!

I tried to build the extension from source code and found some bugs.

When I run the commands :

npm install 
vsce package

The following errors are occured :

Executing prepublish script 'npm run vscode:prepublish'...

> vscode-emacs-tab@0.0.9 vscode:prepublish
> npm run compile

> vscode-emacs-tab@0.0.9 compile
> tsc -p ./

src/extension.ts:125:3 - error TS1068: Unexpected token. A constructor, method, accessor, or property was expected.                          

125   {
      ~

src/extension.ts:126:8 - error TS1005: ';' expected.

126   "key": "tab",
           ~

src/extension.ts:127:14 - error TS1005: ';' expected.

127     "command": "tab",
                 ~

src/extension.ts:128:13 - error TS1005: ';' expected.

128       "when": "editorTextFocus && !editorReadonly && !editorTabMovesFocus"
                ~

src/extension.ts:130:3 - error TS1128: Declaration or statement expected.

130   private createRegExp(s: string): RegExp {
      ~~~~~~~

src/extension.ts:130:25 - error TS1005: ',' expected.

130   private createRegExp(s: string): RegExp {
                            ~

src/extension.ts:130:34 - error TS1005: ';' expected.

130   private createRegExp(s: string): RegExp {
                                     ~

src/extension.ts:130:36 - error TS1434: Unexpected keyword or identifier.

130   private createRegExp(s: string): RegExp {
                                       ~~~~~~

src/extension.ts:141:1 - error TS1128: Declaration or statement expected.

141 }
    ~

Found 9 errors in the same file, starting at: src/extension.ts:125
****
Executing prepublish script 'npm run vscode:prepublish'...

> vscode-emacs-tab@0.0.9 vscode:prepublish
> npm run compile

> vscode-emacs-tab@0.0.9 compile
> tsc -p ./

src/test/index.ts:13:29 - error TS2307: Cannot find module 'vscode/lib/testrunner' or its corresponding type declarations.                   

13 import * as testRunner from 'vscode/lib/testrunner';

So, I fixed the followings.

Sorry for multiple changes in a single PR, but this PR make the package to be more self-contained.

garaemon commented 2 years ago

Thanks!