Remove git hooks

[borys-ihnatyev]

How about remove lint and test run from pre-commit hook?

• I think this actions should be performed only on the CI, when you make a pull request.

Could you please share your opinion about this?

[sergii-trotsiuk]

In this case not checked commits will be merged to master branch after pull request approve.

[kolesnik]

I am agree with @borys-ihnatyev it is better to use IDE lint validation, and we are not merging pull requests with red builds (if validation is failing)

[disist]

I am agree also, this improvement can provide comfortable developing process for us, without transitional stuff.

[stremann]

@borys-ihnatyev could you create a pull request for that?

[sergii-trotsiuk]

@kolesnik I talk not about red builds I talk about commits which contain not checked code. For example, developer made commit C1 without lint validation and after that made commit C2 with fixes according to lint validation. CI server allow pull request and C1 commit merge to master.

[kolesnik]

yep it's possible but this PR will not pass review

[sergii-trotsiuk]

So reviewer should check each commit for as lint on code review? Not diff tab and just logic mistakes? I think it doesn't work. So if we move lint validation from Git hooks to CI server, we must accept the fact that some commits in master will not be validated with lint. @borys-ihnatyev Why do you want remove lint from Git hooks?

[kolesnik]

It is not possible when we are merging only PRs with green builds. Also we are doing "Squash and merge" for each PR it means that only one validated commit is placed to the master.

[sergii-trotsiuk]

Squash fix this situation. Just in case, @kolesnik are you going to save npm script for lint validation?

[kolesnik]

I don't think that we need separate script for that, we are sharing lint config via .eslintrc.json

[sergii-trotsiuk]

How do you propose run lint on CI server? During production build script (npm script)?

[borys-ihnatyev]

@sergey-trotsyuk We have CI to lint our code (pull requests), and if you want you can lint manually on your machine before pull request (npm run lint) or turn on eslint in WebStorm or your IDE/Text editor. I am not sure why should we care about every commit to be linted, it is out of process to push directly into master.

[borys-ihnatyev]

@sergey-trotsyuk we already have lint check on CI https://github.com/garage-it/SmartHouse-backend/blob/master/.travis.yml#L12

[sergii-trotsiuk]

@borys-ihnatyev So we save lint script. Ok, let's try.

[borys-ihnatyev]

59