search

garage-it / SmartHouse-backend

9 stars 2 forks source link

[TG-246][tech] add user and auth endpoints #64

Closed AstakhovArtem closed 7 years ago

review-ninja commented 7 years ago

ReviewNinja

codecov-io commented 7 years ago

Current coverage is 93.85% (diff: 95.04%)

Merging #64 into master will increase coverage by 0.47%

@@             master        #64   diff @@
==========================================
  Files            44         53     +9   
  Lines           514        635   +121   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            480        596   +116   
- Misses           34         39     +5   
  Partials          0          0

Powered by Codecov. Last update 66136e7...7322f7b

sergii-trotsiuk commented 7 years ago

This pull request is blocker for TG-244, TG-246, TG-247, TG-250. So we will merge it. And up coverage later.

sergii-trotsiuk commented 7 years ago

1) # Scenario Model #Save/Update will stop inactive scenario: Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.

It's erratic test. Will fixed later.