search

garageScript / curriculum

GarageScript Curriculum
21 stars 164 forks source link

Refactor away Chai #343

Closed onlurking closed 3 years ago

onlurking commented 4 years ago

Several tests across generalAlgorithms, interviewPrep, js7 and j8 are using chai:

const expect = require('chai').expect

but the dependency is not declared in package.json.

songz commented 3 years ago

TODO: Migrate tests to all use jest.

onlurking commented 3 years ago

@songz can you assign me? working on it.

onlurking commented 3 years ago

@songz @ggwadera done, just opened PR #360