garagepoort / StaffPlusPlus

The ultimate moderation plugin
GNU General Public License v3.0
42 stars 25 forks source link

Duplication Glitch while entering staff mode. #234

Open alternatemedicine opened 9 months ago

alternatemedicine commented 9 months ago

So, I honestly didn't want to post this here, as it will most likely do more harm than good. But if you enter staff and then really quickly drop an item, that item will be duped, as it will exist on both the ground and the player's inventory. This may not be too significant, as only staff can actually abuse this, but in the server I am an admin on, even low level staff members have permissions to use /staff. This means that someone abusing this dupe is extremly likely. I am currently not able to post any videos, but I will as soon as I can. Please fix ASAP

alternatemedicine commented 9 months ago

One method I can think of to prevent this issue is to cancel any dropitem calls or move item to container calls a couple ticks before entering staff mode. This will add a slight delay to the command, but it will prevent an issue like this.