garann / template-chooser

Tool to help select the right template engine for a project.
http://garann.github.com/template-chooser/
476 stars 66 forks source link

This app is totally broken #10

Closed adardesign closed 11 years ago

adardesign commented 12 years ago

After choosing something and changing a later or previous selection it doesn't update as it should

garann commented 12 years ago

Totally broken? Oh no. Do you think there's any point in trying to fix it, or should I just voluntarily exile myself to a new career as a carrot farmer in Uruguay? If you think there's a chance some crumb of usefulness can be chipped from the facade of frustrating impotence, maybe you could tell me a little more about what isn't updating and what your environment looks like?

adardesign commented 12 years ago

first, sorry for calling it totaly broken.

Sure, ill try to explain you what happened, (wish i can screencast it)

Using chrome canary (Version 20.0.1132.43) // maybe thats why i had this expireince.

When i choose the first option (client or server) from the series of questions it behaves as expected, it narrowed down the list of templates according to my selction, great!

All seems to be working fine.

But when i then go to the 3rd question, it hides all of the templates, but now even if i go back and change the first and or the second question, it still has "all templlates" hidden.

Thanx anyway

garann commented 12 years ago

You can call it totally broken or anything else you like, as long as you explain what needs to be fixed. :)

What you're describing sounds like a problem I'm aware of, but haven't yet fixed. The tool works as a process of elimination, but there's no way to un-set a given option, taking it out of the equation. I'll comment again when I add that in, and hopefully it will work for you at that point. Thanks for explaining!

adardesign commented 12 years ago

Thanks much!

On Fri, Jun 29, 2012 at 11:04 AM, Garann Means < reply@reply.github.com

wrote:

You can call it totally broken or anything else you like, as long as you explain what needs to be fixed. :)

What you're describing sounds like a problem I'm aware of, but haven't yet fixed. The tool works as a process of elimination, but there's no way to un-set a given option, taking it out of the equation. I'll comment again when I add that in, and hopefully it will work for you at that point. Thanks for explaining!


Reply to this email directly or view it on GitHub: https://github.com/garann/template-chooser/issues/10#issuecomment-6662971

ravi commented 11 years ago

Garann, the tool is actually enormously useful -- I did not even know about Transparency until I used the tool! But the issue is a bit larger than unsetting a choice. Even flipping a choice in a particular way causes somewhat erratic behaviour (that can be cleared by reloading the page). E.g: leave everything else as-is, and open the DOM structure question and select DOM. Now click on DOM again. Then click on String. The choices go blank. Clicking some number of times on String brings the relevant choices back into view, and/or clicking back on DOM followed by String in a sequence of clicks returns the correct values. I haven't had the time to figure out the algorithm to induce the right behaviour once the strangeness starts, nor have I had a chance to look at your code to see what could be causing this. I would like to do the latter though, in case I can submit a patch/pull. In the meantime, documenting my finding here. Thank you for the tool itself. Very helpful.

xixixao commented 11 years ago

I confirm ravi's findings, on FF18. The tool looks great though, thanks .)

garann commented 11 years ago

@ravi - thanks for the steps to reproduce! Should be fixed now.

ravi commented 11 years ago

@garann looks good, I cannot reproduce the problem any longer. Thank you for the fix.