garbados / dat-gateway

In-memory Dat to HTTP gateway
https://dat.bovid.space/
61 stars 13 forks source link

Merge RangerMauve fork #8

Closed garbados closed 5 years ago

garbados commented 6 years ago

@RangerMauve has added a number of fixes and features, and I'd like to see about merging them upstream and getting them into NPM. This PR will track the merging process.

garbados commented 6 years ago

I am currently hesitant about merging because tests fail on my system.

$ git clean -dxf && npm i && npm test
Removing node_modules/
Removing package-lock.json
npm WARN deprecated graceful-fs@3.0.11: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js

> sodium-native@2.2.1 install /home/garbados/code/dat-gateway/node_modules/sodium-native
> node-gyp-build "node preinstall.js" "node postinstall.js"

> utp-native@1.7.3 install /home/garbados/code/dat-gateway/node_modules/utp-native
> node-gyp-build

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN eslint-plugin-react@6.10.3 requires a peer of eslint@^2.0.0 || ^3.0.0 but none is installed. You must install peer dependencies yourself.

added 563 packages from 741 contributors and audited 1940 packages in 10.327s
found 0 vulnerabilities

> dat-gateway@2.0.1-beta test /home/garbados/code/dat-gateway
> standard && dependency-check . --unused --no-dev && mocha

Success! All dependencies in package.json are used in the code

  dat-gateway
    ✓ should exist
    ✓ should handle requests (3060ms)
    ✓ should handle requests for dead addresses (3008ms)
    1) should proactively deleted expired archives
    2) should handle websockets for replication
node: ../deps/uv/src/unix/udp.c:67: uv__udp_finish_close: Assertion `!uv__io_active(&handle->io_watcher, 0x001 | 0x004)' failed.
Aborted (core dumped)
npm ERR! Test failed.  See above for more details.
RangerMauve commented 6 years ago

Yeah, I'll see if I have time next weekend (29th) to work on this some more. At the moment I've got my hands full with other stuff. 😅

RangerMauve commented 5 years ago

Question: Would you mind adding me as a collaborator so that I could add features through new branches on here instead of my fork?

garbados commented 5 years ago

Sure! Let me get right on that.

garbados commented 5 years ago

It seems that you are already a collaborator, @RangerMauve :)

RangerMauve commented 5 years ago

Oh sweet! 😁 Thank you