search

garbagemule / MobArena

MobArena plugin for Minecraft
GNU General Public License v3.0
193 stars 151 forks source link

Have you considered adding boss support for MagicSpells? #347

Open Thaumcraft4Lyfe opened 7 years ago

Thaumcraft4Lyfe commented 7 years ago

Here - https://github.com/TheComputerGeek2/MagicSpells

He said he'd be willing to do it iirc. This would allow for a wider, more customizable range of boss abilities. It would be awesome to be able to make bosses cast MagicSpells.

TheComputerGeek2 commented 7 years ago

@Thaumcraft4Lyfe I do not recall saying that I was going to create a means of bosses casting spells. What I had said was that I would be looking into possibilities on reworking the integration of MobArena/MagicSpells so that I could pitch an idea here. The closest we would be able to get to bosses casting spells would be them running commands to execute locations spells, but as of current, there isn't a means of mobs actually casting spells based upon their current location. It can be faked, but not fully done.

@garbagemule if you're up for a little reworking of the MagicSpells integration, I'd be up for it. Would you prefer it becomes an external plugin (an addon) or just reworking the internal integrations?

garbagemule commented 7 years ago

Hi friends,

My biggest gripe with plugin integrations is the trouble that comes with maintaining them. That's why I have been reluctant to introducing dependencies in the past.

@TheComputerGeek2 If there is any way you can strip out the MagicSpells integration from MobArena completely and stick it in its own little addon, that would be absolutely fantastic. It would remove an integration point from the core plugin and place the responsibility of maintenance on the addon developer instead of me. If that developer is you, this is a Good Thing™, for two reasons: 1) you know more about MagicSpells than I do, and 2) you are probably more active than I am :)

I assume we'd have to go through some refactoring of MobArena and also add some more hooks, but if they can be made somewhat reusable, I'd love to dig into it.

Thoughts?

TheComputerGeek2 commented 7 years ago

@garbagemule it should be fairly easy for me to create an integration plugin for the two plugins. And believe me, there is a lot I'd like to do. However, until then, I can also offer some easy modifications to the existing system which would make it easier for spells to be filtered on usage. I introduced a system of data tags which can be specified for each spell in their configuration. In addition, I created a tool for intelligently filtering spells based upon those tags in addition to being able to optionally specify white or blacklists. As far as I know, there shouldn't have to be much of a refactoring of the core plugin in order to externalize the MagicSpells integration since it is fairly isolated, if the goal is to maintain only the existing functionality.

But that said, refactoring to add more possible hooks would be amazing and I'd love to look into what we can do with that. And like I mentioned above, being able to have commands run on various events would be wonderful in the core, not only for MagicSpells, but as a generic integration tool.

garbagemule commented 7 years ago

@TheComputerGeek2 I think refactoring all MagicSpells integration into a separate plugin would be a great start. If it's possible without any big changes to MobArena (aside from stripping out the dependency and the relevant code), that would be huge. I think that maintaining existing functionality should be the first milestone. After that, we can look into enhancements to really spice things up :)

TheComputerGeek2 commented 7 years ago

@garbagemule just an update on what I got going on for this: https://github.com/TheComputerGeek2/MSMACompat it is fairly close to being functional.

garbagemule commented 7 years ago

@TheComputerGeek2 I've never seen that massivecraft stuff before, so I had to find time to dig through all the boilerplate, haha. Anyway, good job! I really like this idea of granular control of when spells should and shouldn't be disabled. And this is all without any modifications to MobArena yet, great! Keep up the good work :)

TheComputerGeek2 commented 7 years ago

@garbagemule thanks! And is there anything you'd like to see added as far as integration or should I just follow my own gut on it?

garbagemule commented 7 years ago

@TheComputerGeek2 I'll leave it all up to you - you know way more about MagicSpells than I do, and I'm sure you'll be much more able to keep up with community requests than me anyway ;)

TheComputerGeek2 commented 7 years ago

@garbagemule also, if additional api events can be implemented, that would be great, it would give me more to work with as far as making addons. #349

garbagemule commented 6 years ago

@TheComputerGeek2 thoughts on this issue? Can it be closed? And what of the MagicSpells integration in MobArena - can we strip it out? Would things break if we did?

TheComputerGeek2 commented 6 years ago

@garbagemule I never got around to spending enough time with this, although I'd actually love to have some integration with MS and the bosses. If need be, I can try to clean up the integration solution here. Can't really take on further projects at this moment, but this has been on the todo list for a long time.