garbagemule / MobArena

MobArena plugin for Minecraft
GNU General Public License v3.0
196 stars 150 forks source link

Scoreboard display belowName removed at match start #375

Open Kolgrath opened 7 years ago

Kolgrath commented 7 years ago

I set a scoreboard to show player's health:

/Scoreboard objectives add Health health /Scoreboard objectives setdisplay belowName Health

The health appears correctly on players in the lobby, but as soon as the match starts the health objective disappears. Even when I perform the setdisplay after the match starts, it will not display the player's life in the belowName slot.

As soon as the match ends, player life can be seen once again in the belowName slot.

Is there a way to either allow scoreboards in MobArena or another way to show a player's remaining health over their head?

garbagemule commented 7 years ago

If you set use-scoreboards: false in the config-file, MobArena won't interfere with any scoreboard stuff at all. Does that help?

Kolgrath commented 7 years ago

Setting use-scoreboards: false allows the health to be shown over the players' heads. So definitely a help to the healers.

It's a trade-off though, since many players love to see that scoreboard on the side showing waves and kills.

Maybe eventually showing both could be filed under "feature requests". Love the plugin. In the mob-fighting genre, yours is the best!

mibby commented 7 years ago

@garbagemule I'm experiencing a similar issue with scoreboards. Scoreboards do not seem to restore / revert back on arena end.

I colorize player nametags based on their grouping so they get attached to a scoreboard group when they join the server (using the coloredtags plugin). However, people who join the mobarena and then die, their nametag doesn't revert back to the color they had prior. Their nametag is changed to white until they relog.

Would it be possible to restore their scoreboard groupings on arena end / exit / death when they are no longer part of the arena or spectating?

Compiled MobArena as of commit https://github.com/garbagemule/MobArena/commit/6bbc9b55cff1ad8b9963c02209db545a6294fe10

PVPArena does properly restore scoreboards if you'd like to look at how @slipcor does it.

garbagemule commented 6 years ago

This could be considered a bug and an enhancement. We need to investigate what's actually going on with the scoreboards, and then split this into a fix that fixes whatever bugs we have with it, and an enhancement that adds any missing functionality.

garbagemule commented 6 years ago

Ancient issue, but @mibby and @Kolgrath, would you guys be interested in MobArena providing the health bars in its own scoreboard? I think I have a fix for the non-restoring scoreboards, but that's actually #366, whereas this issue is more about the combination of scoreboards or MobArena picking up a new scoreboard feature.

I'm worried the added player health might actually mess up some people's setups if they use MobArena scoreboards but different plugins for player health bars. I suppose we could just make it a per-arena setting if that's the case.

SaitDev commented 6 years ago

I think display party members 're health on scorecard is better idea (sidebar, not below name), its easier for other member to track

mibby commented 6 years ago

@garbagemule Sorry, just noticed this issue. I currently use a wide range of scoreboard plugins for managing collision, colored player names based on group prefix, and mcmmo for mob health bars. I don't use anything for a sidebar scoreboard, as I personally believe it is a bit too obtrusive set permanently outside of things like arenas.

I wouldn't mind MobArena handling scoreboards while in the arena to display team information like health above their head and the current remaining mob / boss health. However it should possibly be an option to disable and restore former scoreboard state back on leave to prevent issues with players no longer being part of their scoreboard group outside arena state.

Not sure how you would handle plugins that already take care of health displaying without a compatibility hook to prevent duplicate overlap though. (i.e. McMMO or HealthBar plugin).