garbagemule / MobArena

MobArena plugin for Minecraft
GNU General Public License v3.0
194 stars 151 forks source link

The Item drop from boss in arena will remain after the arena end #556

Open ghost opened 5 years ago

ghost commented 5 years ago

Feature request

Short description

Yah . Like if a monster drop the a weapon . Then when you leave arena , the weapon still remain in your inventory . And .. the item you use in arena will lost . It like the inventory in arena and before/after join inventory is one

Implementation details

It should have a config line like Share-item-world . It will remove the class myitems , because all inventory will be one .

This will make the game more fair , because in some case , a player dont do anything still have reward . And with mythicmobs , it is easy to drop some custom item , Very needed to a RPG server

garbagemule commented 4 years ago

If I understand it correctly, this feature request is about treating drops as "rewards" in the sense that they are kept on arena end. Because of the way the code base is structured right now, this is not feasible to try to implement before the sessions rework is over. However, there are some things we need to address before we can start work on this.

Part of the motivation is that "lazy" players are given rewards that they didn't really earn. Some points to consider:

There is another issue with this request, and it's in the assumption that "My Items" is just "one" inventory that transcends the arena sessions. This is not true. All inventory items are restored on arena end, even if using the "My Items" class. But this opens up a new potential feature: being able to use "My Items" in a way that the inventory is only saved on death and restored on respawn. This means that if I join with 10 health potions and use 3, then die, I'll come out of the arena with 7 health potions, even though I died. In a "hardmode" version, I may leave with an empty inventory.