Arena signs created for arenas that don't have kebab-case style names in the config-file never update after creation.
Reproduction steps
Create an arena with a name like "Area 53"
Create an arena sign for the given arena (just use the default info template)
Join the arena and observe that the sign does not update
Doing the same thing with arena name like "a1" produces the expected results of the signs updating.
Details
MobArena version: 0.106
Server version: Spigot 1.17.1
Stacktrace (if applicable): N/A
Additional info
The problem is that the procedure that handles arena events uses the configName() method to find the "arena ID", which is the wrong behavior. The "arena ID" is the arena slug, and configName() actually returns the verbatim name from the config-file, which means the lookup in the sign store's findByArenaId() method will fail.
Bug report
Short description
Arena signs created for arenas that don't have
kebab-casestyle names in the config-file never update after creation.Reproduction steps
infotemplate)Doing the same thing with arena name like "a1" produces the expected results of the signs updating.
Details
Additional info
The problem is that the procedure that handles arena events uses the
configName()method to find the "arena ID", which is the wrong behavior. The "arena ID" is the arena slug, andconfigName()actually returns the verbatim name from the config-file, which means the lookup in the sign store'sfindByArenaId()method will fail.https://github.com/garbagemule/MobArena/blob/caee8be6cace6c64bfe16be0047b85136b433018/src/main/java/com/garbagemule/MobArena/signs/HandlesArenaUpdates.java#L74