Open nicholasleejy opened 2 years ago
Not a bad idea.
I think I originally omitted the spectate behavior exactly because I didn't feel up to the task of deciding between an "overloaded" join behavior or separate join and spectate behaviors. I don't think there's anything particularly difficult about either approach.
I don't think having both is a good idea, because it would mean the spectate sign only satisfies the aforementioned edge case of wanting to spectate before an arena starts. I also think overloaded join signs are a bit of a stretch in terms of consistency, because it means it will behave differently from the join command. We could opt to overload both, of course.
There's a third option where overloaded join signs are a setting. I don't really like that idea, mostly because it introduces extra logic and having to pass settings around everywhere, but also because the config-file is already pretty bloated.
I personally would be happy with having another sign template for spectate. I feel as though to the player it's pretty self explanatory, and would be an easy and quick way of implementing it. Having 2 signs isn't particularly a detriment to most server developers, myself included, and I'd actually already accommodated for it in my build, as to me it made the most sense for that to be the functionality.
Copied here from discord on Garbagemule's instruction
Short description A sign that allows you to spectate the arena, instead of using the command /ma spec
Implementation details Similar to how the join sign works, the player can click on the sign of a running arena to teleport to the lobby as a spectator, exactly like how the "/ma spec" command functions.
Possible methods: