garbagemule / MobArena

MobArena plugin for Minecraft
GNU General Public License v3.0
189 stars 150 forks source link

Sign problem 1.20.1 #765

Closed DexterSK closed 8 months ago

DexterSK commented 1 year ago

Bug report

Short description

When you right click on arena sign it will open SignGUI

Reproduction steps

  1. Right click on sign

Details

Additional info

DexterSK commented 1 year ago

Ok so issue is still there, it worked one time but now again doesn't. When i right click sign it will open edit sign gui and console will say player xxx tried to edit non editable sign.

Bobcat00 commented 1 year ago

Is your arena protected by any other plugins, like WorldGuard or GriefPrevention? That seems to be a CraftBukkit message for the cases of the sign being waxed or the wrong player is editing it (don't really understand all this): https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/nms-patches/net/minecraft/world/level/block/entity/TileEntitySign.patch#50

I have a branch that stops the dialog from being opened, but it may not be the perfect solution: https://github.com/Bobcat00/MobArena/commit/2cbb4909fb51b06e48b9018c79787997c91afd39?w=1

DexterSK commented 1 year ago

yup i have wg region

DexterSK commented 1 year ago

do i need to remove region?

veteranmina commented 11 months ago

Haven't really looked, but is this possibly due to the new 1.20 feature of double-sided signs?

BobbyTowers commented 8 months ago

I only get this on the second arena. The first one works fine.

garbagemule commented 8 months ago

@DexterSK @BobbyTowers @veteranmina I've got a fix for this issue ready if anyone wants to try it out. Let me know if you prefer to build it yourself (branch 765-sign-edit) or if you'd like me to send you a build on Discord.

BobbyTowers commented 8 months ago

I would like a build, what's your discord?

garbagemule commented 8 months ago

I'll drop one in the #test-builds channel on the MobArena Discord.

Nesseley commented 8 months ago

For the lazy ones