garbear / xbmc

XBMC Main Repository
http://xbmc.org
Other
132 stars 53 forks source link

Fixed configuration manager #118

Closed cool-pants closed 4 years ago

cool-pants commented 4 years ago

Description

Changed the input condition for configuration wizard from device name to peripheral location.

Superseded by https://github.com/garbear/xbmc/pull/119

Motivation and Context

Earlier the configuration wizard blocked input while mapping based on the device name of peripherals. This means two peripherals with different names won't be able to interfere which each other's mapping process. but at the same time, two with the same name could be mapped to a singular virtual device. This was fixed using the peripheral location instead of the name.

How Has This Been Tested?

Tested using two controllers of the same model and trying to configure both to the same virtual device at the same time. Now only the peripheral which initiates the wizard will be mapped while the input from the other controller will be ignored.

Screenshots (if appropriate):

Types of change

Checklist:

garbear commented 4 years ago

The idea behind this change seems right. I believe m_deviceName is no longer used and can be removed entirely, right? In that case, this PR should be a straight-up replacement of device name with device location. The PR contains a logic change that I don't think is needed. If so, can you split the PR into two commits - one that straight replaces name with location and no other changes, and a second follow-up commit that refactors the logic with an explanation in the commit message why it's needed?

Also, keep an eye on the lines added/lines removed. Every line added or removed should be justified by the PR.