garbear / xbmc

XBMC Main Repository
http://xbmc.org
Other
132 stars 53 forks source link

[GSoC 2020] Python Game API #123

Open NikosSiak opened 3 years ago

NikosSiak commented 3 years ago

Description

This PR extends the Python API to support game metadata, like title, developer, publisher and captions (from #120 ).

Motivation and Context

How Has This Been Tested?

I have wrote a small addon that uses the API to update the discord rich presence status displaying what game you are playing and what you are doing in the game at this moment https://github.com/NikosSiak/service.games.discord.richpresence

image

Screenshots (if appropriate):

Types of change

Checklist:

garbear commented 2 years ago

I've created a test build and uploaded to https://github.com/garbear/xbmc/releases. I tested it out and everything looks good for me. Only issue was the login button in the settings taking a while to give user feedback during the network IO. Adding a spinner would be a good idea.

My only two comments left about the code are the unused variable and the copyright headers.