search

garbear / xbmc

XBMC Main Repository
http://xbmc.org
Other
134 stars 53 forks source link

[cmake/addons] Improve binary addon buildsystem on Windows #56

Closed fetzerch closed 8 years ago

fetzerch commented 8 years ago

These are the patches necessary to compile the scummvm core on windows. (discussion in https://github.com/kodi-game/game.libretro.scummvm/pull/2) Both are however not limited to that core and could likely improve/fix builds for other addons.

734d020 adds msys to the search path. Makefiles that use ${MKDIR} won't work with the Windows built-in version, because that has a different syntax.

a049e63 fixes patches for dependencies on Git that are autocrlf-ed and hence --binary would fail.

Detailed info can be found in the commit messages.

Would like to get an opinion from @Montellese who added that code part. Is it ok to add them to retroplayer for now or should I directly send it upstream?

garbear commented 8 years ago

We'll add to retroplayer now. I can keep the commits separate and we can PR against master when retroplayer is ready (or any time before)

garbear commented 8 years ago

After rebasing on 17 alpha 2, patching add-ons is failing on Jenkins/Win32. My local Win32 workstation doesn't have a problem patching add-ons, so it could be a Jenkins problem.

The rebased commits are 9bf9803...237cc73. I might have introduced a rebase error when updating to alpha 2.

The problem might also lie with PR 7133, which I commented on.