search

garbear / xbmc

XBMC Main Repository
http://xbmc.org
Other
134 stars 53 forks source link

Prefer override VideoPlayer #83

Closed hudokkow closed 7 years ago

hudokkow commented 7 years ago

VideoPlayer counterpart of https://github.com/xbmc/xbmc/pull/12374

It's only the top commit (https://github.com/garbear/xbmc/pull/83/commits/51d9a00197ab0f402c15567819237ef6c83936d9). The rest is rebase artifacts. Your branch is way behind.

garbear commented 7 years ago

Rebased on lastest upstream/vpupdates

hudokkow commented 7 years ago

Yeah, moving target. Better revisit and do it against vpupdates when it stabilizes or PR directly. Thoughts?

garbear commented 7 years ago

@hudokkow Can you PR directly to the VP branch? my fixes use the virtual keyword which we're getting rid of.

Once the override changes are in I'll refocus my PR to deal with the API issues.

hudokkow commented 7 years ago

Okido. I'll pull your branch and update the PR using it as base. Just need to ask my daughter for permission... ;)

EDIT: Sorry, slow reader here. Will PR to vpupdates. Closing this one.

garbear commented 7 years ago

I meant skip my branch and send to vpupdates.

hudokkow commented 7 years ago

Yeap, understood! Already on the third beer...

garbear commented 7 years ago

I'd try catching up, but it's 10am here... :wink: