search

garbear / xbmc

XBMC Main Repository
http://xbmc.org
Other
132 stars 53 forks source link

Parent directory '..' listitem does not exit addon #94

Closed zach-morris closed 5 years ago

zach-morris commented 6 years ago

This may just be how my addon is (poorly) written, as I'm not able to recreate this issue in any other addon I tested (SuperFavorites, Youtube). Feel free to close this if this is just how Kodi works now.

Version tested:

14:59:16.547 T:140735305183232  NOTICE: Starting Kodi (18.0-ALPHA1 Git:20180215-276e1a4). Platform: OS X x86 64-bit
14:59:16.548 T:140735305183232  NOTICE: Using Debug Kodi x64 build
14:59:16.548 T:140735305183232  NOTICE: Kodi compiled Feb 15 2018 by Clang 9.0.0 (clang-900.0.37) for OS X x86 64-bit version 10.8.0 (1080)
14:59:16.548 T:140735305183232  NOTICE: Running on Apple Inc. MacBookPro12,1 with OS X 10.11.6, kernel: Darwin x86 64-bit version 15.6.0
14:59:16.548 T:140735305183232  NOTICE: FFmpeg version/source: 3.4.1-Kodi
14:59:16.549 T:140735305183232  NOTICE: Host CPU: Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz, 4 cores available

Issue: Pressing the '..' Kodi directory item when in an addon does not go to the parent directory and close the addon as expected. Testing the same addon (IARL) in v17 the behavior is different.

Log: [First press of '..' listitem]

09:03:31.579 T:140735305183232   DEBUG: ------ Window Init (Pointer.xml) ------
09:03:31.630 T:140735305183232   DEBUG: ------ Window Deinit (Pointer.xml) ------
09:03:37.311 T:140735305183232   DEBUG: ------ Window Init (Pointer.xml) ------
09:03:38.785 T:140735305183232   DEBUG: ProcessMouse: trying mouse action leftclick
09:03:38.786 T:140735305183232   DEBUG: CGUIMediaWindow::GetDirectory (plugin://plugin.program.iarl/)
09:03:38.786 T:140735305183232   DEBUG:   ParentPath = [plugin://]
09:03:38.788 T:123145304526848   DEBUG: CAddonDatabase::SetLastUsed[plugin.program.iarl] took 2 ms
09:03:38.788 T:123145311580160   DEBUG: StartScript - calling plugin Internet Archive ROM Launcher('plugin://plugin.program.iarl/','9','','resume:false')
09:03:38.788 T:123145302839296   DEBUG: Thread LanguageInvoker start, auto delete: false
09:03:38.788 T:123145302839296    INFO: initializing python engine.
09:03:38.789 T:123145302839296   DEBUG: CPythonInvoker(25, /Users/ZC/Library/Application Support/Kodi/addons/plugin.program.iarl/addon.py): start processing
09:03:38.802 T:123145302839296   DEBUG: -->Python Interpreter Initialized<--
...
09:03:39.444 T:123145302839296    INFO: CPythonInvoker(25, /Users/ZC/Library/Application Support/Kodi/addons/plugin.program.iarl/addon.py): script successfully run
09:03:39.496 T:123145305063424   DEBUG: Thread BackgroundLoader start, auto delete: false
09:03:39.504 T:123145305063424   DEBUG: Thread BackgroundLoader 123145305063424 terminating
09:03:39.534 T:123145302839296    INFO: Python script stopped
09:03:39.534 T:123145302839296   DEBUG: Thread LanguageInvoker 123145302839296 terminating
09:03:39.723 T:140735305183232   DEBUG: ------ Window Deinit (DialogBusy.xml) ------

[Second press of '..' listitem]

09:03:40.711 T:140735305183232   DEBUG: ProcessMouse: trying mouse action leftclick
09:03:40.712 T:140735305183232   DEBUG: CGUIMediaWindow::GetDirectory ()
09:03:40.712 T:140735305183232   DEBUG:   ParentPath = []
09:03:40.721 T:123145302839296   DEBUG: Thread BackgroundLoader start, auto delete: false
09:03:40.725 T:123145302839296   DEBUG: Thread BackgroundLoader 123145302839296 terminating
09:03:41.319 T:140735305183232   DEBUG: ------ Window Deinit (Pointer.xml) ------
garbear commented 5 years ago

I figured out the bug is due to providing multiple types. I've sent a fix here: https://github.com/xbmc/xbmc/pull/14409

zach-morris commented 5 years ago

Confirmed fixed in version:

09:00:11.223 T:140735098916864  NOTICE: Starting Kodi (18.0-BETA2 Git:20180911-84925cfc94). Platform: OS X x86 64-bit
09:00:11.223 T:140735098916864  NOTICE: Using Debug Kodi x64 build
09:00:11.223 T:140735098916864  NOTICE: Kodi compiled Sep 11 2018 by Clang 9.0.0 (clang-900.0.37) for OS X x86 64-bit version 10.9.0 (1090)
09:00:11.223 T:140735098916864  NOTICE: Running on Apple Inc. MacBookPro12,1 with OS X 10.11.6, kernel: Darwin x86 64-bit version 15.6.0
09:00:11.223 T:140735098916864  NOTICE: FFmpeg version/source: 4.0.2-Kodi
09:00:11.223 T:140735098916864  NOTICE: Host CPU: Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz, 4 cores available