garbled1 / homeassistant_ecowitt

Ecowitt Weather Station integration for homeassistant
Apache License 2.0
143 stars 70 forks source link

Migrate device classes to StrEnum #131

Open james-pinckney opened 2 years ago

james-pinckney commented 2 years ago

The "Last Lightning Strike" sensor wasn't working so I put this PR together to try and fix the issues. Included are links to the PRs in core that were used as reference to create these changes. Seems to be working fine with the sensors I have here and now I have lightning data again.

Migrate from DEVICECLASS* to StrEnum... https://github.com/home-assistant/core/pull/60654 https://github.com/home-assistant/core/pull/60651

Fix timestamp return format... https://github.com/home-assistant/core/pull/52671

DoerakkerHA commented 2 years ago

[custom_components.ecowitt] Unhandled sensor type runtime value 408056, file a PR. [custom_components.ecowitt] Unhandled sensor type runtime value 408117, file a PR. [custom_components.ecowitt] Unhandled sensor type runtime value 408178, file a PR. [custom_components.ecowitt] Unhandled sensor type runtime value 408239, file a PR.

sam-ward commented 2 years ago

This repo seems to be largely abandoned at the moment. It’s worth noting though that there is an ecowitt integration coming in HA core with 2022.9 (according to the change log).

On Wed, Sep 7, 2022, at 2:42 PM, DoerakkerHA wrote:

[custom_components.ecowitt] Unhandled sensor type runtime value 408056, file a PR. [custom_components.ecowitt] Unhandled sensor type runtime value 408117, file a PR. [custom_components.ecowitt] Unhandled sensor type runtime value 408178, file a PR. [custom_components.ecowitt] Unhandled sensor type runtime value 408239, file a PR.

— Reply to this email directly, view it on GitHub https://github.com/garbled1/homeassistant_ecowitt/pull/131#issuecomment-1238972894, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF2YVB6YS3LQQE7BCIL2S3V5A2N5ANCNFSM54CBZQ7A. You are receiving this because you are subscribed to this thread.Message ID: @.***>