search

garden-io / garden

Automation for Kubernetes development and testing. Spin up production-like environments for development, testing, and CI on demand. Use the same configuration and workflows at every step of the process. Speed up your builds and test runs via shared result caching
https://garden.io
Mozilla Public License 2.0
3.39k stars 274 forks source link

0.13: [Bug]: Changing ingress configuration in a Deploy action from dev mode does not update ingress on fresh `deploy` #4213

Closed worldofgeese closed 1 year ago

worldofgeese commented 1 year ago

Garden Bonsai (0.13) Bug

Current Behavior

Changing the ingress configuration for a Deploy action inside dev mode doesn’t get picked up: garden doesn’t update the service on a new deploy.

E.g. change /hello to / while garden dev is running. Please see Empathy Session doc (restricted to employees of garden.io) for full context starting from 40:00 in.

image

image

Expected behavior

Dev mode should automatically update the ingress.

Reproducible example

https://github.com/shumailxyz/nestjs-typeorm-auth-starter/tree/gardenify

Workaround

To work around, @shumailxyz killed garden dev then ran garden deploy.

Your environment

garden version Bonsai latest as of May the 8th.

vvagaytsev commented 1 year ago

Sorry, pls ignore my previous (deleted) comments. I think I've misread the description. Need to watch the video recording to grab the full context.

Orzelius commented 1 year ago

Currently this is intentional behavior. You can run reload in the dev terminal to reload the project if there are any changes to garden configs.

There's a case made of making this known to the users.

worldofgeese commented 1 year ago

If users are expecting different behavior, is there an argument to be made to change the behavior? As a user, I'd expect ingress to update on a new deploy.

Orzelius commented 1 year ago

closed via https://github.com/garden-io/garden/pull/4256