search

garden-io / garden

Automation for Kubernetes development and testing. Spin up production-like environments for development, testing, and CI on demand. Use the same configuration and workflows at every step of the process. Speed up your builds and test runs via shared result caching
https://garden.io
Mozilla Public License 2.0
3.39k stars 274 forks source link

0.13: [Bug]: Logic for parsing Dockerfiles and computing inclusions is missing for action configs #5523

Open vvagaytsev opened 11 months ago

vvagaytsev commented 11 months ago

The logic for parsing Dockerfiles and computing the file inclusions from them is only being used for module configs, not action configs. That needs to be fixed.

Current Behavior

Dockerfiles are parsed and processed only when using module configs.

Expected behavior

Dockerfiles should be parsed and processed when using both action and module configs.

Reproducible example

Workaround

None.

Suggested solution(s)

Additional context

See containerHelpers.autoResolveIncludes helper.

Your environment

garden version 0.13.21

vvagaytsev commented 11 months ago

This was discovered while debugging #5317. Thanks, @thsig!

thsig commented 9 months ago

I seem to recall this being fixed the other day—do you remember, @vvagaytsev?

vvagaytsev commented 9 months ago

@thsig yes, we still need to fix it. I haven't had a chance to do it so far.