search

garden-rs / garden

Garden grows and cultivates collections of Git trees ~ Official mirror of https://gitlab.com/garden-rs/garden
https://garden-rs.gitlab.io
MIT License
66 stars 9 forks source link

Use fenix latest stable rustc 1.78.0 #37

Closed jordilin closed 5 months ago

jordilin commented 5 months ago

Fenix contains latest rustc 1.78.0 while nixpkgs unstable lags bit behind at 1.77.2. This commit brings the flake to latest stable rust build components. Also, one can control which version of rustc can be used independently of nixpkgs by just using fenix's provided toolchains (nightly, etc...)

Before (my current system at 1.76.0)

rustc --version
rustc 1.76.0 (07dca489a 2024-02-04) (built from a source tarball)

Now:

rustc --version
rustc 1.78.0 (9b00956e5 2024-04-29)

Also, add .envrc so anyone can automatically activate flake on entering the repository.

davvid commented 5 months ago

Thanks Jordi! This started catching additional clippy fixes which I fixed up in 5772bd387c07fac3ae0594c4a6f990bf14760436.

Interestingly, I also had to apply 66bfbff7811aa7ff775bbf28be759252ec63f628 to get nix flake check to build -- perhaps llvm-tools isn't available since it kept erroring out with error: attribute 'x86_64-linux' missing.

I'm not sure if that was the right fix since it basically removed llvm-coverage, but I wasn't really using that so it didn't seem like a concern to me at least.

jordilin commented 5 months ago

Well, I see the issue - if you want to re-enable llvm I submitted another PR here #38 - I pass cargo test and nix flake check