search

garden-stream / garden

shared resources
0 stars 2 forks source link

Updates proposed to the user resource #21

Closed NathanBland closed 7 years ago

NathanBland commented 7 years ago

What am I missing? @keawade @crodeheaver

keawade commented 7 years ago

LGTM

crodeheaver commented 7 years ago

@NathanBland How do you differentiate displayName vs username?

Assuming you don't care about any other info, it also LGTM.

NathanBland commented 7 years ago

Display name could be something like Joe Smith, where as username would be joeSmith.

On Mon, Nov 7, 2016, 2:35 PM Colby Rodeheaver notifications@github.com wrote:

@NathanBland https://github.com/NathanBland How do you differentiate displayName vs username?

Assuming you don't care about any other info, it also LGTM.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/garden-stream/garden/pull/21#issuecomment-258970045, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4hn8S0-E4GR41Y0_c1Au5Tut0meouqks5q75mEgaJpZM4KruQN .

crodeheaver commented 7 years ago

@NathanBland Then why not take a last name and first name, then make that a computed property? I'm fine with the display name, I typically just do the first/last name separated to allow easier searching on those fields. So it's up to you since searching happens on the server. 😉

NathanBland commented 7 years ago

Well, it may not be first & last name at all. Just what you want it to be

On Mon, Nov 7, 2016, 2:44 PM Colby Rodeheaver notifications@github.com wrote:

Then why not take a last name and first name, then make that a computed property? I'm fine with the display name, I typically just do the first/last name separated to allow easier searching on those fields. So it's up to you since searching happens on the server. 😉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/garden-stream/garden/pull/21#issuecomment-258972571, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4hn8QLrIOEr_mU8Tnao_4la0Pp9ZAFks5q75vHgaJpZM4KruQN .

keawade commented 7 years ago

Perhaps we should require a first name and last name and default display name to the users first name?

EDIT: I don't really see any reason to include first or last name. Are we okay with users being anonymous to us? I think that would be fine and maybe even preferable.

NathanBland commented 7 years ago

I'm counting this as approval then