garden / tree

A multiplayer file system
https://thefiletree.com
European Union Public License 1.2
70 stars 23 forks source link

Add HTTP header Last-Modified #137

Closed jankeromnes closed 12 years ago

jankeromnes commented 12 years ago

In FS, file dates are touched on:

However, FS::File objects are created very often, I'm not sure why. I added a console log whenever a File object is created, look at the logs when you browse and open files in your browser, you might be surprised. This causes, among other things, the Last-Modified field to reset to current time when you open or close a file, even if there was no modification.

espadrine commented 12 years ago

I think we should use the disk's "last modified" information when loading a file (with new File()).

But yes, we are loading files often. It's a bitter-sweet compromise that takes care of the fact that the OT-file system isn't done yet :)

jankeromnes commented 12 years ago

Disk's last modified sounds nice, but that would require rewriting part of the driver. I think the current implementation is good for now :)