search

garden / tree

A multiplayer file system
https://thefiletree.com
European Union Public License 1.2
70 stars 23 forks source link

OT: Unnecessary closing of file in the file system. #160

Closed espadrine closed 12 years ago

espadrine commented 12 years ago

Plugs using both {{=file.content}} and OT have a bug wherein the nth time, n > 1, that they are run, file.content would yield null. This change fixes that bug.

espadrine commented 12 years ago

@jankeromnes, you mention this bug in #157.

jankeromnes commented 12 years ago

Indeed. Why was the file closed at this point? Is it going to stay open forever after this change?

espadrine commented 12 years ago

On Sun, Nov 25, 2012 at 4:55 PM, Jan Keromnes notifications@github.com wrote:

Indeed. Why was the file closed at this point? Is it going to stay open forever after this change?

No. In fact, it gets closed in the on('disconnect', function(){}) closure.

jankeromnes commented 12 years ago

Ok, sounds good. I'll merge this tonight.

jankeromnes commented 12 years ago

I'll merge this next week, let's see if our uptime holds for a month without crashing :)