Plug: plug=none on a directory.

garden / tree

A multiplayer file system

https://thefiletree.com

European Union Public License 1.2

70 stars 23 forks source link

Plug: plug=none on a directory. #164

Closed espadrine closed 11 years ago

espadrine commented 11 years ago

Fixes #134 and #147.

It implements the behaviour specified in #147. Requesting a directory with no plugs returns a newline-separated list of entry names.

jankeromnes commented 11 years ago

Got the ping, will look at this in the next few days. Sorry for the delay, I can't seem to find a place to settle down before moving to the next one!

jankeromnes commented 11 years ago

Merged as b5575c4f1d349d394526749fcd6ec63f1609db0e . I guess I owe you many apologies:

For letting this awesome code wait for 2 long months
For rebasing your commit on top of other commits (you'll have to reset, be careful not to lose any work!)
For adding formidable as a dependency in a commit not reviewed in a pull request: b14107f69de0e869dee5aefaf6168eef36bd8d5b

I hope this won't cause you any trouble.

espadrine commented 11 years ago

For adding formidable as a dependency in a commit not reviewed in a pull request: b14107f

Forgiven, but never do that again.

However, since there was no code review for it, let's do a post-code review.

The commit 0fd60a3 is wrong for a very simple reason. It installs formidable at node_modules/formidable, while Camp hosts the formidable library at node_modules/camp/node_modules/formidable. The idea is to use formidable through Camp. It's more integrated and easier to use.