garden / tree

A multiplayer file system
https://thefiletree.com
European Union Public License 1.2
70 stars 23 forks source link

type.js calls drivers "mime types" #192

Closed jankeromnes closed 11 years ago

jankeromnes commented 11 years ago

@espadrine in type.js:

Those are not mime types. We should change the occurrences of "mime type" in type.js to "type", and fs.js:138 should not set file.meta.type to type.nameFromType[file.type]. Mime types should instead be looked up properly.

This confusion causes all new mime types to be wrongly set to "binary" or "text" (however, in our logic "dir" is a valid mime type for folders, should we change that?), these problems surface in #188.

jankeromnes commented 11 years ago

Well, now that we're accepting driver types and mime types as just "types" this is not an issue anymore...