garden / tree

A multiplayer file system
https://thefiletree.com
European Union Public License 1.2
70 stars 23 forks source link

default mime type for files without extensions should be "text/plain" #193

Closed jankeromnes closed 11 years ago

jankeromnes commented 11 years ago

Our current type system assumes that files without extensions are binary.

While that is a common assumption is OSes, I believe it is wrong and unnerving (especially in tree) for the following reasons:

@espadrine please let's change our type logic to default to the text/plain mime type when no extension was found.

jankeromnes commented 11 years ago

Following discussion on IRC, it seems that adding a "type": { "": "text/plain" } entry in /'s metadata fixes the problem. No need to make the whole type system default to "text/plain".

@espadrine said he'll add this in his next pull request, which is exciting :)

espadrine commented 11 years ago

Note: pull request #195 fixes the undermining issue.

jankeromnes commented 11 years ago

Fixed!