search

garden20 / dashboard

Provides a welcome page, a top menu bar, and app installation and management for Garden apps.
4 stars 7 forks source link

Old settings/config not reapplied when update fails #90

Open henokgetachew opened 10 years ago

henokgetachew commented 10 years ago

Once the update fails, default settings and configurations are restored and old configuration is lost.

Here's a screen grab from the Javascript console: dashboard-update-failure

The update failed during merge: merging-step

ghost commented 10 years ago

I have a fix for the gateway timeout over in https://github.com/medic/medic-webapp/issues/625 (read: the 504 isn't being caused by garden or the dashboard). However, I think we should leave this open – we shouldn't ever get into a situation where a loss of connectivity results in lost data and/or a non-functioning dashboard. I've seen both happen; I'll try to get more details later today.

mandric commented 8 years ago

I think we are seeing the same thing here: https://github.com/medic/medic-webapp/issues/1610

At the moment it's a flaw in design and requires a refactor to fix. https://github.com/garden20/dashboard/blob/master/packages/dashboard-core/lib/dashboard_core.js#L264

If the connection drops the new ddoc is left without settings. We should probably copy old settings to the ddoc or even the temp ddoc first and then proceed with migrating settings after.