PA Review: User Auth

[gardenFiend138]

• [x] Backend: DB, model, controller, views
• [x] Redux Loop: ajax, actions, reducer
• [x] Presentational Components
• [x] Styling
• [x] Smooth, bug free navigation
• [ ] Adequate and appropriate seeds

[ajansel]

Some notes:

• Errors need cleared (for example, when I try to login with blank credentials the errors render but then when I click sign up, they are still there but shouldn't be)
• The splash page content is still not displaying correctly
• A hover effect that changes color on the dropdown would be a nice added touch
• "The Lounge", "Top Rated", "All Whiskies" does not look centered in the nav bar. You may want to add some margin to the top so that it is centered appropriately
• It lets me sign up without entering an email, it should not let them and render an error (unless you have a strong preference otherwise)

[gardenFiend138]

Hi AJ,

Thanks for the feedback!

• login errors clear now
• background image still not working for me, github workaround didn't work, hopefully cloudinary will when I add in photo uploads
• I like the dropdown hover effect--I'll add that in!
• Navbar centering--I noticed that, am adding it to my fix list!
• I am going to require an email, i just took off the db validation for testing
• I'll definitely remove all debuggers and print statements by the end!

Also, thinking about scraping friends, but keeping the cheers, and making photo upload for checkins and user profile a main goal. Thoughts?

On Tue, Nov 28, 2017 at 11:12 AM, Andrew (AJ) Ansel < notifications@github.com> wrote:

Some notes:

• Errors need cleared (for example, when I try to login with blank credentials the errors render but then when I click sign up, they are still there but shouldn't be)
• The splash page content is still not displaying correctly
• A hover effect that changes color on the dropdown would be a nice added touch
• "The Lounge", "Top Rated", "All Whiskies" does not look centered in the nav bar. You may want to add some margin to the top so that it is centered appropriately
• It lets me sign up without entering an email, it should not let them and render an error (unless you have a strong preference otherwise)

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/gardenFiend138/UnCaskd/issues/1#issuecomment-347631687, or mute the thread https://github.com/notifications/unsubscribe-auth/AZBQiP2UNHf6ToI6c0EUZhUjtPQZfb4uks5s7FsVgaJpZM4QmhAi .

[ajansel]

Guy, no problem! I love what you did with the homepage!

• Nicely done with the errors!
• Seems like the background photo ended up working okay?
• I like the hover effect a lot!
• Looks like the centering is good now!
• Gotcha that makes sense! It doesn't look like it renders that it can't be blank though.
• Good deal!

Thoughts: Yep, that seems fine. Friends doesn't look like it was a major MVP. And yeah having cheers, photo upload, and user profile sound great.

A couple last things:

• When signup fails you will notice the form expands outside your modal. You may want to style your modal having a 'min-width' instead of 'width'. This should make it at minimum the size you have it but allow it to grow when it is larger.
• When you try to sign up and it fails, then click on 'login', the state does not change (similar to how the errors would stay on the page). But, I actually don't think this is a bad thing because it makes it very easy for the user if they were on the same page! I just wanted to point it out to you incase it wasn't intentional and to point out some websites choose not to do this.
• Don't forget to seed!