Gardenctl update enhancement.

gardener-attic / gardenctl

Command-line client for the Gardener.

Other

56 stars 42 forks source link

Gardenctl update enhancement. #482

Open tedteng opened 3 years ago

tedteng commented 3 years ago

Describe the bug The update feature only displays the information currently

gardenctl update

New version "v0.24.0" of Gardenctl is available at https://github.com/gardener/gardenctl/releases/latest
Please get latest version from above URL and see https://github.com/gardener/gardenctl#installation for how to upgrade

I like to install the latest version or previous version with a version number in local when using the update feature

neo-liang-sap commented 3 years ago

could you please remove Describe the bug from description? it's not a bug, when you open new issue other than bug please choose "open blank issue"
from user perspective i don't see any reason why they should revert to an old version, we should always encourage user to use latest version of gardenctl. If you'd like to revert back to some previous version due to development purpose, then it's should be a development utilization tool, not released to customer.

By literal meaning, update means to a higher version, we should not include rollback / revert function unless we are in a production deployment scenario, obviously gardenctl is not for this kind of scenario.

neo-liang-sap commented 3 years ago

/invite @dansible , what do you think?

gardener-robot commented 3 years ago

@neo-liang-sap Command /invite is not allowed for issue but only for pullrequest.

tedteng commented 3 years ago

about the update feature (gardenctl update), as I mentioned above the current process needs manual installation. which is my main purpose, regarding the older version installation is not the main pain point for me now. just an extra feature. I am not too worry about older version installation part, I am fine without this part. besides, the command of an older version installation maybe like gardenctl install old version something like. I think you can get the idea is not literal mean you need gardenctl update old version. don't worry about it. I will more force on the update automation part as that is my mean pain point now.

gardenctl update

New version "v0.24.0" of Gardenctl is available at https://github.com/gardener/gardenctl/releases/latest
Please get latest version from above URL and see https://github.com/gardener/gardenctl#installation for how to upgrade

tedteng commented 3 years ago

andrei-panov commented 3 years ago

add --make-backup flag? Then for the previous version, you can run prev_gardenctl ?

tedteng commented 3 years ago

It could be, but I haven't decided whether need to handle the previous version yet or how to handle it in the proper ways. but I think the auto-upgrade is more useful now.