Add cpu topology settings and possibility to overcommit guest overhead

gardener-attic / gardener-extension-provider-kubevirt

Gardener Extension Provider for KubeVirt

Other

11 stars 16 forks source link

Closed mfranczy closed 3 years ago

mfranczy commented 3 years ago

Signed-off-by: Marcin Franczyk marcin0franczyk@gmail.com

How to categorize this PR?

/area performance /kind enhancement /priority normal /platform kubevirt

What this PR does / why we need it: It allows to set CPU topology and supports memory overcommit

Which issue(s) this PR fixes: Fixes #36

Special notes for your reviewer:

Release note:

improvement_user

mfranczy commented 3 years ago

Please do not merge yet, that change breaks API. It will be possible to merge this when I am done with MCM provider kubevirt.

mfranczy commented 3 years ago

as we spoke I will rebase against master and add validation

mfranczy commented 3 years ago

@stoyanr I will resolve conflicts and not to block you, let's merge it and I will open another PR with validation

mfranczy commented 3 years ago

@stoyanr rebase is done.

stoyanr commented 3 years ago

/lgtm