search

gardener-attic / gardener-resource-manager

Kubernetes resource reconciliation controller capable of performing health checks for managed resources.
https://gardener.cloud
5 stars 19 forks source link

Enhance GRM to read annotations #122

Closed harishmanasa closed 3 years ago

harishmanasa commented 3 years ago

What this PR does / why we need it: The gardener-resource-manager is enhanced to read annotations from Deployments, StatefulSets and DaemonSets as well. This includes the annotations from the metrics-server to avoid addon-resizer clashing with gardener-resource-manager.

Special notes for your reviewer: This PR will be ready for review once it is tested

Release note:

Don't overwrite resources/replicas of objects annotated with `resources.gardener.cloud/preserve-{resources,replicas}`.
gardener-robot-ci-2 commented 3 years ago

Thank you @harishmanasa for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

harishmanasa commented 3 years ago

Hi @timebertt could you take a look at the unit tests, and suggest any changes if required?

timebertt commented 3 years ago

BTW: you can run make verify to execute the checks locally without waiting for the pipeline.

harishmanasa commented 3 years ago

Hi @timebertt, could you take a look at the changes? And make verify is executing fine without errors locally

harishmanasa commented 3 years ago

/ready

timebertt commented 3 years ago

To speed up the PR review, I pushed a commit with some changes to adhere to the API conventions: https://github.com/timebertt/gardener-resource-manager/commit/278a62686c22e180283a62b325c21846c41eb5b1

Unfortunately, I couldn't push to your branch, because you used the protected master branch. So you can now cherry-pick my change to your branch.

Once that is done, this PR can be merged. I tested and verified everything locally 👍

harishmanasa commented 3 years ago

Thank you so much Tim, for taking time out for the commit and testing :) I'll cherry pick your commit at the earliest

timebertt commented 3 years ago

Unfortunately seems like golang needs to be updated for this repo:

>> make generate
make generate needs to be run:
 M api/go.sum

https://concourse.ci.gardener.cloud/builds/21092848#L60d628f6:30:32

timebertt commented 3 years ago

Done in https://github.com/gardener/gardener-resource-manager/pull/124