Add the Support for OpenStack Designate DNS provider

gardener-attic / kubify

Terraform Template to Setup a Kubernetes Cluster on OpenStack/AWS/Azure

Other

147 stars 31 forks source link

Add the Support for OpenStack Designate DNS provider #69

Closed jiangytcn closed 3 years ago

jiangytcn commented 5 years ago

Using openstack designate dns provider for private cloud installation.

afritzler commented 5 years ago

Thanks a lot for the PR.

jiangytcn commented 5 years ago

thanks @afritzler kubify is quite new to me, and even I create the PR for supporting openstack dns, but I need to commend out route53 setting in dns module, otherwise the deployment would be failed. this the dns setting in terraform.tfvar

dns = {
  domain_name = "int.yacloud.io"
  dns_type = "designate"
  hosted_zone_id = "77f75ba6-ada2-4c3e-b0a8-ba9f2e0b61b0"
}

Did i miss anything ?

provider.aws.route53: No valid credential sources found for AWS Provider. Please see https://terraform.io/docs/providers/aws/index.html for more information on providing credentials for the AWS Provider

afritzler commented 5 years ago

@mandelsoft can you help @jiangytcn out to include another DNS provider type in our module structure?

jiangytcn commented 5 years ago

thanks @afritzler @mandelsoft lemme know if need any further information

afritzler commented 5 years ago

Can you please rebase and squash this PR?

CLAassistant commented 4 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

afritzler commented 3 years ago

Closing due to inactivity. Please feel free to reopen it.