gardener-community / cloudprofiles

A public collection of gardener cloudprofiles
2 stars 1 forks source link

Filter GitHub latest release #18

Closed mxmxchere closed 1 year ago

mxmxchere commented 1 year ago

This commit https://github.com/gardener-community/cloudprofiles/commit/e932cf66fed1b9aa5043b110b93463c93f04bb2a actually downgraded the cloudprofiles to a bunch of no longer supported versions instead of tracking the new ones. I think this happened because k8s v1.24.14 was marked as "latest" release which fits in terms of it being released least but not being the latest in terms of all availible supported minors.

Approach to fix this:

  1. get latest (highest minor) supported release in the values.yaml
  2. get latest github-release
  3. if minor-local > minor latest -> exit

This approach assumes that every "greatest" minor will be marked as "latest" at some point in time in the github releases. This is (as seen) not always true, but if it is true at one point in time it is enough to let the tracker track forward and do not step backwards

mxmxchere commented 1 year ago

Ok, now a little bit of release cleaning aftermath. We had 3 Releases due to that issue:

0.6.0: introduced k8s 1.27 (fine) 0.6.1: downgraded latest to 1.24 (thats bad) 0.7.0: upgraded to 1.27 again (ok, but the minor jump is unfortunate)

As none of those releases is used in any gardener installation yet (and can not be used either as k8s 1.27 is not supported in any gardener version). I will:

It should create a new 0.6.1 release with patch jumps for 1.24 and 1.27 at least, maybe for other versions too.